Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test: Put SyncChurn to last #4578

Closed
wants to merge 1 commit into from
Closed

Integration Test: Put SyncChurn to last #4578

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Put SyncChurn to last in integration test

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 12, 2024 06:36
@eval-exec eval-exec requested review from quake and removed request for a team August 12, 2024 06:36
@eval-exec
Integration Test: Put SyncChurn to last
45bef52 
Signed-off-by: Eval EXEC <execvy@gmail.com>
chenyukang
chenyukang reviewed Aug 12, 2024
View reviewed changes
test/src/main.rs
@@ -591,6 +590,8 @@ fn all_specs() -> Vec<Box<dyn Spec>> {
Box::new(CheckVmVersion2),
Box::new(CheckVmBExtension),
Box::new(RandomlyKill),
// SyncChurn : This is a CPU-intensive operation, so we place it last.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the run order is random?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@eval-exec eval-exec closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang left review comments

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @chenyukang