Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test: wait find unverified blocks finish before insert invalid block #4594

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Integration Test: wait find unverified blocks finish before insert invalid block #4594

merged 1 commit into from
Aug 16, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • In BlockSyncNonAncestorBestBlocks, wait nodes find unverified blocks finish before inserting invalid blocks.

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 16, 2024 03:58
@eval-exec eval-exec requested review from zhangsoledad, chenyukang and driftluo and removed request for a team August 16, 2024 03:58
@eval-exec eval-exec added the t:test: Integration Test Type: This issue is related to test. label Aug 16, 2024
@eval-exec eval-exec closed this Aug 16, 2024
@eval-exec eval-exec reopened this Aug 16, 2024
@eval-exec eval-exec added this pull request to the merge queue Aug 16, 2024
Merged via the queue into nervosnetwork:develop with commit 925e736 Aug 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
t:test: Integration Test Type: This issue is related to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @chenyukang