Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test: do not kill gracefully on windows #4624

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Integration Test: do not kill gracefully on windows #4624

merged 1 commit into from
Aug 29, 2024
+8 −20

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Integration Test: Do not kill gracefully on windows

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec
Do not kill gracefully on windows
3a40e37 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec requested a review from a team as a code owner August 29, 2024 03:37
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team August 29, 2024 03:37
@eval-exec
Copy link
Collaborator Author

I think windows CI workflows will success after merge this PR. @driftluo

@eval-exec eval-exec added this pull request to the merge queue Aug 29, 2024
Merged via the queue into nervosnetwork:develop with commit f9c3c70 Aug 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@chenyukang chenyukang Awaiting requested review from chenyukang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @driftluo