Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4676, Remove empty entry for OrphanPool #4677

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Backport #4676, Remove empty entry for OrphanPool #4677

merged 1 commit into from
Oct 16, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 15, 2024 •
edited
Loading

What problem does this PR solve?

backport #4676
When an entry in OrphanPool is empty, it should be removed.

What is changed and how it works?

What's Changed:

Related changes

  • Remove empty entry in OrphanPool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 15, 2024 03:46
@eval-exec
remove empty by_out_point entry
c353dee 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/0.119.x-fix-high-memory-backport-4676 branch from b257f59 to c353dee Compare October 16, 2024 01:39
@eval-exec eval-exec changed the title Backport #4676, Destruct TransactionView to get wtx_hash Backport #4676, Remove empty entry for OrphanPool Oct 16, 2024
@zhangsoledad zhangsoledad merged commit c4dd450 into nervosnetwork:rc/v0.119.x Oct 16, 2024
32 checks passed
@doitian doitian mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @zhangsoledad