Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for defmt log using a new feature #54

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Georges760
Copy link
Contributor

No description provided.

@eval-exec
Copy link
Collaborator

Hello @Georges760 Will this PR cause performance loss?

@eval-exec
Copy link
Collaborator

eval-exec commented Sep 14, 2024

I exeucted cargo bench on master, then execute cargo bench again on your PR, it seems that some bench case report performance loss about 20%, and some case performance improved

@Georges760
Copy link
Contributor Author

Nope it is just a formatting for debug purpose, so in production should not be enable.

@Georges760
Copy link
Contributor Author

It is like the Serde derive, just an additional feature optional

@eval-exec
Copy link
Collaborator

Nope it is just a formatting for debug purpose, so in production should not be enable.

OK, it's seem that cargo bench's result is not stable.

@zhangsoledad zhangsoledad added this pull request to the merge queue Sep 23, 2024
Merged via the queue into nervosnetwork:master with commit b528490 Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants