Make the parameter save to connect_peer optional

nervosnetwork · Oct 21, 2024 · 31dd8b3 · 31dd8b3
1 parent c0d3bec
commit 31dd8b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/rpc/README.md b/src/rpc/README.md
@@ -241,6 +241,7 @@ Attempts to connect to a peer.
 ###### Params
 
 * `address` - The address of the peer to connect to
+* `save` - Whether to save the peer address, an optional parameter (default value true)
 
 ###### Returns
 

diff --git a/src/rpc/peer.rs b/src/rpc/peer.rs
@@ -12,7 +12,7 @@ use tentacle::{multiaddr::MultiAddr, secio::PeerId};
 #[derive(Serialize, Deserialize, Debug, Clone)]
 pub(crate) struct ConnectPeerParams {
     address: MultiAddr,
-    save: bool,
+    save: Option<bool>,
 }
 
 #[serde_as]
@@ -46,7 +46,7 @@ impl PeerRpcServer for PeerRpcServerImpl {
     async fn connect_peer(&self, params: ConnectPeerParams) -> Result<(), ErrorObjectOwned> {
         let message =
             NetworkActorMessage::Command(NetworkActorCommand::ConnectPeer(params.address.clone()));
-        if params.save {
+        if params.save.unwrap_or(true) {
             crate::handle_actor_cast!(
                 self.actor,
                 NetworkActorMessage::Command(NetworkActorCommand::ConnectPeer(