[WIP] Broadcast {channel,node} information for multihop payment #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation because of message change
Convert between molecule and rust types
Add AnnoucementSignature to message union
use a dedicated type for announced node name
Broadcast node announcement messages
Refactor peer id in channel state
Save peer pubkeys to channel
Make signature field in channel {announcement, update} optional
Get channel announcement message from channel state
Return complete tx status on TraceTx
Do not panic on node announcement command
Define CFNBroadcastMessage for broadcast messages
chenyukang
reviewed
Aug 15, 2024
| #[derive(Debug)] | ||
| pub struct TraceTxResponse { | ||
| pub tx: Option<ckb_jsonrpc_types::TransactionView>, | ||
| pub status: ckb_jsonrpc_types::TxStatus, |
There was a problem hiding this comment.
it's better to import ckb_jsonrpc_types, since there are multiple references.
chenyukang
reviewed
Aug 15, 2024
src/fiber/channel.rs
Outdated
| &self, | ||
| state: &mut ChannelActorState, | ||
| message: FiberMessage, | ||
| message: FiberChannelNormalOperationMessage, |
There was a problem hiding this comment.
FiberChannelMessage is better?
chenyukang
reviewed
Aug 15, 2024
| ) | ||
| .await; | ||
| // Wait for the channel announcement to be broadcasted | ||
| tokio::time::sleep(tokio::time::Duration::from_millis(5000)).await; |
There was a problem hiding this comment.
seems need to add assertion here.
There was a problem hiding this comment.
Yes. I was trying to add an expected event so that we can be sure this is working. As I hinted on the discord server, I think it would be better if we can just see all the messages sent to the network actor. I had some problem implementing some kind of introspection functionality. I can add a NetworkServiceEvent for ChannelAnnouncement here, but I found NetworkServiceEvent had became somewhat bloated.
chenyukang
reviewed
Aug 15, 2024
chenyukang
reviewed
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.