-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate sphinx for onion message obfuscation #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
force-pushed
the
onion-sphinx
branch
from
September 26, 2024 00:45
374b285
to
ccef6bc
Compare
doitian
force-pushed
the
onion-sphinx
branch
from
September 29, 2024 07:41
9464440
to
042c425
Compare
doitian
force-pushed
the
onion-sphinx
branch
from
September 29, 2024 07:56
042c425
to
9aed208
Compare
chenyukang
reviewed
Sep 29, 2024
let mut peeled_packet_bytes: Option<Vec<u8>> = None; | ||
|
||
if !add_tlc.onion_packet.is_empty() { | ||
// TODO: Here we call network actor to peel the onion packet. Indeed, this message is forwarded from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we passing the private_key
to channel state when creating channel actor, i'm not sure which way is better.
chenyukang
reviewed
Sep 29, 2024
Comment on lines
+146
to
+149
// SendPaymentOnionPacket(peeled_packet_buf, previous_tlc), | ||
// The first parameter is the peeled onion in binary via `PeeledOnionPacket::serialize`. `PeeledOnionPacket::current` | ||
// is for the current node. | ||
SendPaymentOnionPacket(Vec<u8>, Option<(Hash256, u64)>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better comment style in line 151~152 .
chenyukang
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more in the sphinx implementation repo https://github.com/cryptape/fiber-sphinx
What's changed?
fiber/src/fiber/types.rs
Lines 2718 to 2737 in 5685f40