feat: add shutdown_script to rpc #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
reviewed
Oct 3, 2024
tests/bruno/e2e/cross-chain-hub/13-node1-send-shutdown-channel.bru
Outdated
Show resolved
Hide resolved
contrun
approved these changes
Oct 3, 2024
| @@ -100,6 +102,12 @@ pub async fn main() { | |||
| node_public_key.clone().into(), | |||
| ))); | |||
|
|
|||
| let secret_key = ckb_config.read_secret_key().unwrap(); | |||
| let secp = Secp256k1::new(); | |||
There was a problem hiding this comment.
Using secp256k1_instance in src/fiber/types.rs is better, because that function only initialize secp251k1 instance once and keep it in memory (there are many places we need to use the secp256k1 instance).
This reverts commit 7525b17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR reverted some changes of #174 by reusing the
shutdown_scriptfield of ChannelActorState, and added an optional field to the rpcopen_channelandaccept_channel.