check CKB amount range when open channel #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
yukang-fix-ckb-amount-range
branch
from
6922c0f to
7517427
Compare
chenyukang
force-pushed
the
yukang-fix-ckb-amount-range
branch
from
7517427 to
3d6fa95
Compare
quake
reviewed
Oct 22, 2024
Co-authored-by: Quake Wang <quake.wang@gmail.com>
Co-authored-by: Quake Wang <quake.wang@gmail.com>
chenyukang
force-pushed
the
yukang-fix-ckb-amount-range
branch
from
f984369 to
d25e82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #252, upgrade ckb-rust-sdk will resolve the issue, but user can not get a proper error message since it's an error handled by auto accept code.
This pr add an extra check to make sure CKB amount is less than
u64::max, since we useu128for all amount considering UDT amount.