Use molecule for hopdata and tlc_err #425
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #425 +/- ##
===========================================
+ Coverage 49.80% 49.85% +0.05%
===========================================
Files 47 47
Lines 29806 31090 +1284
===========================================
+ Hits 14845 15501 +656
- Misses 14961 15589 +628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chenyukang
force-pushed
the
use-bincode-for-hopdata
branch
3 times, most recently
from
c498de4 to
397ed27
Compare
chenyukang
changed the title
chenyukang
force-pushed
the
use-bincode-for-hopdata
branch
from
397ed27 to
a2461cc
Compare
chenyukang
force-pushed
the
use-bincode-for-hopdata
branch
from
a2461cc to
4e835c3
Compare
| next_hop: PubkeyOpt, | ||
| } | ||
|
|
||
| // A ChannelUpdate is a update to the public channel. Newer channel information may be updated with |
There was a problem hiding this comment.
I prefer to keep ChannelUpdate in gossip.mol, as it is logically more consistent. What is the rational of moving this struct? Did you encountered cyclic dependency issue?
There was a problem hiding this comment.
TlcErrData contains a filed of ChannelUpdate, and it seems is weird if we add TlcErrData in gossip
Line 1116 in 6c18519
any other better way.
removed duplicated unit test by the way.