Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite shannonToCKB with lumos formatUnit #3114

Merged
merged 1 commit into from
Apr 11, 2024
Merged

refactor: rewrite shannonToCKB with lumos formatUnit #3114

merged 1 commit into from
Apr 11, 2024

Conversation

twhy
Copy link
Contributor

@twhy twhy commented Apr 10, 2024

After the discussion in #3111, I realized that we just need to rewrite shannonToCKB with formatUnit.

@twhy twhy mentioned this pull request Apr 10, 2024
Closed
homura
homura approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Keith-CY Keith-CY merged commit 71bb064 into nervosnetwork:develop Apr 11, 2024
10 checks passed
@twhy twhy deleted the refactor/rewrite-shannonToCKB-with-formatUnit branch April 11, 2024 04:09
@twhy twhy mentioned this pull request Apr 11, 2024
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@devchenyan devchenyan devchenyan approved these changes

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@twhy @Keith-CY @homura @devchenyan @yanguoyu