Replace inline-css package

[aoor9]

This PR would finally solve (discontinued) vm2 vulnerability by replacing the outdated inline-css with css-inline.

fixes #723, #923, #668, #691

please check #608, #732, #360

[elsheraey]

@juandav It would be great if this got merged.

[saratscheff]

LGTM

[AnvarAka1]

Please, review the PR. It is critical for the project, that I am working on.
Thanks beforehand!

[BramRoets]

@juandav Could this please get merged?

This package has been causing a critical security issue for almost 2 months. Many of us will have a blocked pipeline because of this dependency. Is there anything that needs to happen before this can get merged?

[pharindoko]

@juandav @cdiaz please can you approve and merge this ?

[poojakharel]

@juandav @eduardoleal @cdiaz @p-mcgowan please approve and merge this pr

[pharindoko]

Thanks @juandav

[SzymonGonet]

That's how poppin 💪🏻

[Stranger6667]

Hey, css-inline author here. If you find any issues with inlining (or missing features), feel free to report them directly to the project issues list and tag me there. Hopefully, switching to css-inline would be beneficial for mailer, not only in the context of security vulnerabilities :) Cheers

[pharindoko]

@juandav
Can you create a new release that includes this PR ?

[pharindoko]

@juandav release please ! :)

[loic-combis]

Thanks for fixing this security issue!

@juandav, is there an ETA on when this will be released?

[GMBermeo]

Worked fine on local.

[GMBermeo]

Please, don't forget this.
Deploying something with a clear message "should not be used for production" is very bad.

@juandav

[pharindoko]

Please create a release! @juandav

[marco-verbeek]

Thank you for fixing the issue; could you please create a release for it? 🙏🏼

cc @juandav @cdiaz @dantehemerson @krzysztofmeler

[BramRoets]

I've moved away from this package and started using Nodemailer directly. (Which was pretty easy to implement.)

Unfortunately, this package is not production-ready and is not actively maintained. Security incidents are ignored for months...

[pharindoko]

@BramRoets good idea
you have some simple sample code to share to get started ?

[BramRoets]

@BramRoets good idea you have some simple sample code to share to get started ?

Here is something that should get you started. You might have to tweak the loadPartials method, or fully remove it if you are not using it.

https://gist.github.com/BramRoets/fa8d4dfe7b284654a2da528953669f74

[MallarDev]

Is there a release date for the new version, @juandav?

[kurbar]

@MallarDev If interested, I forked the repo to create a v1.9.2 release - https://www.npmjs.com/package/@kurbar/mailer
Its the latest state of master as-is and will eventually remove it after a grace period when this repo finally makes a release.

[elsheraey]

@pharindoko You could also check this: https://medium.com/@boladebode/exploring-the-new-release-of-nest-js-version-10-and-the-migration-from-nest-modules-mailer-b80c574f89e6

Gratefully had spare time to do it just to see this beautiful status on Snyk 🗡️

Also -1 star to this repo. for not even having an expected release date... The release issue can be resolved but the fact that there was another issue I wanted help resolve but was afraid it will be this much delayed got me out :")

Thanks to the contributors anyways as I have used it for a while.

[pharindoko]

@pharindoko You could also check this: https://medium.com/@boladebode/exploring-the-new-release-of-nest-js-version-10-and-the-migration-from-nest-modules-mailer-b80c574f89e6

Gratefully had spare time to do it just to see this beautiful status on Snyk 🗡️

Also -1 star to this repo. for not even having an expected release date... The release issue can be resolved but the fact that there was another issue I wanted help resolve but was afraid it will be this much delayed got me out :")

Thanks to the contributors anyways as I have used it for a while.

nice hint! :) thanks @elsheraey

[nikolaivasilev12]

Can we please get a release on this? Its a pity to have the code merged for a almost two months now, but be missing a release on it... Our devs are being blocked by our pipelines due to it....

[Leccho]

@juandav Are you still maintaining?

[LenoM]

Adding this code may help workaround the issue while we wait for the solution:

package.json
"overrides": { "degenerator": "5.0.1" },
"dependencies": { ...

[davidulman]

@juandav Are you still maintaining?
We are waiting to the release for two months

[GreenFlag31]

Guys, just use the nodemailer without the @nestjs-modules/mailer which is not maintained anymore. This is simple and you have one dependancy less !
https://medium.com/@boladebode/exploring-the-new-release-of-nest-js-version-10-and-the-migration-from-nest-modules-mailer-b80c574f89e6

Sending a mail is a question of 10 lines of code. After having implemented it, I don't even see the added value of @nestjs-modules/mailer.