Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basedir option added to configuration for generate command #2415

Merged

Conversation

yigitkurtcu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Issue Number: #1849

What is the new behavior?

Added a new option "baseDir". With this new option, new files related to this directory will be created and imported to the app module.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@micalevisk
Copy link
Member

image

looks like we need to fix our CI

@wildyaboku
Copy link

Any news on this @micalevisk @yigitkurtcu? Can we re-run the integration tests?

I was investigating because the official nest-cli schema has baseDir as an option, but it wasn't working and the generate action had no relevant code. Looks like the PR has not been merged yet.

@yigitkurtcu
Copy link
Contributor Author

Is there any chance the CI have been fixed? Can I do anything about that? @micalevisk

@micalevisk
Copy link
Member

@yigitkurtcu Not sure. Rebase your push and do a force push to it so it'll rerun the CI

@yigitkurtcu yigitkurtcu force-pushed the feat/generate-options-base-url branch from c246cdf to 877b6bd Compare May 26, 2024 23:00
@yigitkurtcu
Copy link
Contributor Author

CI seems to be fixed. @micalevisk

@kamilmysliwiec kamilmysliwiec merged commit 537dfa7 into nestjs:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants