Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit with an error when some config file was found but lacks on reading permissions #2446

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jan 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: closes #2434

What is the new behavior?

exit with an error. See:

demo.mp4

We got the same output for nest generate command

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@micalevisk micalevisk changed the title fix: exit with an error when some config file was found but lacks of reading permissions fix: exit with an error when some config file was found but lacks on reading permissions Jan 14, 2024
@kamilmysliwiec kamilmysliwiec merged commit bc3c0f8 into nestjs:master Feb 5, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odd behavior when the config file can't be read
2 participants