Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve :param retrieval in prefix in middleware #13886

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

CodyTseng
Copy link
Contributor

@CodyTseng CodyTseng commented Aug 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13401, #9776

PR #11832 caused issue #9776 when a global prefix was set and the exclude parameter was configured. Therefore, I reverted PR #11832 and fixed the issue it addressed using an alternative approach.

I added test cases based on the minimal reproduction code provided in #13401. This PR also resolves the issue in #13401.

The recent issues with middleware execution not behaving as expected all originate from PR #10390, which was implemented to resolve issue #9776. However, it has become clear that the changes introduced in that PR had too broad an impact. Therefore, in this PR, I have adjusted the logic so that the changes from PR #10390 only apply in cases where the prefix path contains :param, thereby minimizing the effect on most users.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build b968c84f-c249-4618-83c5-cc0f355b039a

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 92.226%

Totals Coverage Status
Change from base Build 71551605-c356-4a76-8f46-8de2acf07906: 0.01%
Covered Lines: 6762
Relevant Lines: 7332

💛 - Coveralls

@CodyTseng CodyTseng changed the title [WIP] fix: middlewares not executed when root path is excluded fix(core): resolve :param retrieval in prefix in middleware Aug 14, 2024
@CodyTseng CodyTseng marked this pull request as ready for review August 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants