Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fastify): upgrade light-my-request to 6.1.0 #14064

Merged

Conversation

PattyTrish
Copy link
Contributor

@PattyTrish PattyTrish commented Oct 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: upgrade light-my-request to 6.1.0

What is the current behavior?

Seeing a security scan issue from Mend regarding a vulnerability with cookie, a dependency of light-my-request.

light-my-request v6.1.0 upgrades the affected package

The vulnerability is detailed here: https://www.mend.io/vulnerability-database/CVE-2024-47764

Issue Number: N/A

What is the new behavior?

Mend security scan will no longer flag this dependency for repositories using the Fastify platform.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build c062ef34-d197-4da6-99a1-1fc5e448923c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.213%

Totals Coverage Status
Change from base Build 9327011d-4e25-476d-80b9-dcb00dcd9e2d: 0.0%
Covered Lines: 6750
Relevant Lines: 7320

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added dependencies Pull requests that update a dependency file priority: medium (3) Medium priority issue that needs to be resolved labels Oct 16, 2024
@kamilmysliwiec kamilmysliwiec merged commit 6ada824 into nestjs:master Oct 16, 2024
3 checks passed
@kamilmysliwiec kamilmysliwiec removed the priority: medium (3) Medium priority issue that needs to be resolved label Oct 16, 2024
@PattyTrish PattyTrish deleted the cookie-vulnerability-update branch November 4, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants