Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): removed types for socket.io #9665

Merged
merged 1 commit into from
May 31, 2022

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented May 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Removed dependencie @types/socket.io as it is deprecated (see here)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Maybe we can add this to the v9 branch 😻?

@Tony133 Tony133 mentioned this pull request May 25, 2022
12 tasks
@Tony133
Copy link
Contributor Author

Tony133 commented May 25, 2022

There is now package-lock.json, but CI fails

@Tony133
Copy link
Contributor Author

Tony133 commented May 25, 2022

The CI gives this error:

npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nestjs/graphql@10.0.12
npm ERR! Found: ts-morph@15.0.0
npm ERR! node_modules/ts-morph
npm ERR!   dev ts-morph@"15.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional ts-morph@"^13.0.2 || ^14.0.0" from @nestjs/graphql@10.0.12
npm ERR! node_modules/@nestjs/graphql
npm ERR!   dev @nestjs/graphql@"10.0.12" from the root project
npm ERR!   peer @nestjs/graphql@"^10.0.0" from @nestjs/apollo@10.0.12
npm ERR!   node_modules/@nestjs/apollo
npm ERR!     dev @nestjs/apollo@"10.0.12" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: ts-morph@14.0.0
npm ERR! node_modules/ts-morph
npm ERR!   peerOptional ts-morph@"^13.0.2 || ^14.0.0" from @nestjs/graphql@10.0.12
npm ERR!   node_modules/@nestjs/graphql
npm ERR!     dev @nestjs/graphql@"10.0.12" from the root project
npm ERR!     peer @nestjs/graphql@"^10.0.0" from @nestjs/apollo@10.0.12
npm ERR!     node_modules/@nestjs/apollo
npm ERR!       dev @nestjs/apollo@"10.0.12" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/circleci/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2022-05-25T10_20_12_079Z-debug-0.log

Exited with code exit status 1

but it doesn't seem to relate to the changes I've made

@Tony133 Tony133 force-pushed the chore/removed-types-socket-io branch from 20ac120 to 6f48b28 Compare May 30, 2022 07:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build c718c34f-2c17-4f7b-885a-2edfa33d3887

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.107%

Totals Coverage Status
Change from base Build cb79d43d-9c61-441f-89d1-304eaf5d4ee4: 0.0%
Covered Lines: 5781
Relevant Lines: 6143

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 6b38ce1 into nestjs:master May 31, 2022
@Tony133 Tony133 deleted the chore/removed-types-socket-io branch May 31, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants