Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1166 Exception with Code generator when an attribute name has no alfanumeric characters #1190

Conversation

FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Oct 18, 2024

Breaking change

Proposed change

fixes a corner case in codegen like if an attribute has the name "----------------" as descibed in #1166

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (ecc9b9c) to head (d664048).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1190   +/-   ##
====================================
- Coverage    82%     82%   -1%     
====================================
  Files       196     196           
  Lines      3820    3820           
  Branches    428     428           
====================================
- Hits       3166    3161    -5     
- Misses      487     492    +5     
  Partials    167     167           
Flag Coverage Δ
unittests 82% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankBakkerNl FrankBakkerNl enabled auto-merge (squash) October 19, 2024 17:43
@FrankBakkerNl FrankBakkerNl merged commit b9c730e into net-daemon:main Oct 24, 2024
7 of 8 checks passed
@FrankBakkerNl FrankBakkerNl deleted the fix_codegen_attributes_without_valid_chars branch October 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception with Code generator when an attribute name has no alfanumeric characters
2 participants