Add Redis Sentinel config as environment vars #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: None
New Behavior
Allow to configure Redis Sentinel via environment variables. This change does not break existing configurations.
Contrast to Current Behavior
Cannot configure Redis Sentinels without using extra config mechanism.
Discussion: Benefits and Drawbacks
If environment variable
REDIS_SENTINELS
orREDIS_CACHE_SENTINELS
are not defined, the resulting configuration will be an empty list[]
. Upstream netbox also defaults it to[]
(redis tasks, redis cache).I chose to not default
REDIS["cache"]["SENTINELS"]
to redis tasks Sentinels (as it is done forHOST
andPORT
for example), becauseSENTINELS
always takes precedence over direct connection. And one may want to use Sentinels for a redis instance but not the other one.Benefits:
Changes to the Wiki
I don't think any
Proposed Release Note Entry
Allow to configure Redis Sentinels via environment variables
Double Check
develop
branch.