Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing REMOTE_AUTH config options #1144

Merged
merged 3 commits into from
May 25, 2024

Conversation

hendrikbl
Copy link
Contributor

@hendrikbl hendrikbl commented Jan 30, 2024

Related Issue: #992

New Behavior

All REMOTE_AUTH condifuration settings are now configurable via environment variables.
A list of all available options can be found here: https://github.com/netbox-community/netbox/blob/develop/docs/configuration/remote-authentication.md

Contrast to Current Behavior

Currently only the following optiosn are configurable via environment variables:

REMOTE_AUTH_ENABLED
REMOTE_AUTH_BACKEND
REMOTE_AUTH_HEADER
REMOTE_AUTH_AUTO_CREATE_USER
REMOTE_AUTH_DEFAULT_GROUPS

Discussion: Benefits and Drawbacks

This change makes configuration more consistent since most of the configuration should be done in .env files if possible.

Changes to the Wiki

None

Proposed Release Note Entry

Make all REMOTE_AUTH config options configurable via environment variables

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge
Copy link
Member

Please use the provided PR template an target the develop branch.

@hendrikbl
Copy link
Contributor Author

Please use the provided PR template an target the develop branch.

Oh sorry, don't know how I messed this up. I updated the PR with the correct template.

@hendrikbl hendrikbl changed the base branch from release to develop January 30, 2024 11:52
@empusas
Copy link

empusas commented Feb 3, 2024

Why not also include the most common SSO integrations variables as suggested in this issue:
#1139

@hendrikbl
Copy link
Contributor Author

Why not also include the most common SSO integrations variables as suggested in this issue: #1139

I'm not sure if it's a good idea to knowingly put only a few configuration parameters for SOCIAL_AUTH_ in there. I think it leads to confusion if some of them are configured via env and some are not.
But that's something the maintainers have to decide I guess @tobiasge

Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This lgtm.

@cimnine cimnine merged commit 2bbb2d1 into netbox-community:develop May 25, 2024
@tobiasge tobiasge mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants