Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STARTTLS option. #277

Merged
merged 2 commits into from
May 14, 2020
Merged

Add STARTTLS option. #277

merged 2 commits into from
May 14, 2020

Conversation

mbchristoff
Copy link
Contributor

@mbchristoff mbchristoff commented Apr 20, 2020 •
edited
Loading

Related Issue: none

New Behavior

Add ability to enable STARTTLS for ldap server using the same variable as the non-docker version of NetBox.

Contrast to Current Behavior

Add ability to enable STARTTLS using docker-compose.override.yml

Discussion: Benefits and Drawbacks

  • Easier way to enable STARTTLS instead of editing "ldap_config.py" directly.

Changes to the Wiki

Add "AUTH_LDAP_START_TLS: "True"" or "AUTH_LDAP_START_TLS: "True"" to LDAP section of the Wiki.

Proposed Release Note Entry

Add STARTTLS support using docker-compose.override.yml

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

tobiasge
tobiasge requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@tobiasge tobiasge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're settings AUTH_LDAP_START_TLS to a string, but it should be a boolean. Have a look at how it done with LDAP_IGNORE_CERT_ERRORS.

@mbchristoff mbchristoff requested a review from tobiasge April 20, 2020 13:42
@tobiasge
Copy link
Member

Ok, looks good now.
Could you squash both commits into one? Then I will merge it.

@mbchristoff
Copy link
Contributor Author

mbchristoff commented Apr 21, 2020 •
edited
Loading

Ok, looks good now.
Could you squash both commits into one? Then I will merge it.

GitHub has a nice button for that, why not use that one?

@cimnine cimnine added this to the 0.24.0 milestone May 14, 2020
@tobiasge tobiasge merged commit bed40b0 into netbox-community:develop May 14, 2020
@tobiasge tobiasge mentioned this pull request May 15, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

@tobiasge tobiasge Awaiting requested review from tobiasge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbchristoff @tobiasge @cimnine