Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move default source image to Python 3.8 #333

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Move default source image to Python 3.8 #333

merged 2 commits into from
Sep 1, 2020

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Sep 1, 2020

Related Issue:

New Behavior

Upgrade Python base image to 3.8

Contrast to Current Behavior

Discussion: Benefits and Drawbacks

  • Keep current with patches

Changes to the Wiki

Proposed Release Note Entry

Python base image updated to 3.8

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

cimnine
cimnine reviewed Sep 1, 2020
View reviewed changes
.github/workflows/push.yml Outdated Show resolved Hide resolved
@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Sep 1, 2020
cimnine
cimnine approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so nice to see the tests all green again ❤️

@tobiasge tobiasge merged commit b33a509 into netbox-community:develop Sep 1, 2020
@tobiasge tobiasge deleted the python-3.8 branch September 1, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine