Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldap configuration in /etc/netbox/config/ldap/*.py not loaded #354

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

comphilip
Copy link
Contributor

Related Issue: #352

New Behavior

Fix LDAP configuration in /etc/netbox/config/ldap/*.py loaded but not sync to django LDAP settings.

Contrast to Current Behavior

LDAP configuration in /etc/netbox/config/ldap/*.py loaded but not sync to django ldap settings.

Discussion: Benefits and Drawbacks

Benefits: Fix bug

Drawbacks: None

Changes to the Wiki

None

Proposed Release Note Entry

None

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine
Copy link
Collaborator

cimnine commented Oct 27, 2020

Thank you for investigating and the PR. Could it make sense to add the same functionality to configuration.docker.py?

@cimnine cimnine added this to the 0.26.1 milestone Oct 27, 2020
@cimnine cimnine added bug This issue describes a confirmed bug. hacktoberfest-accepted We think that such a PR is sufficiently good contribution, even if we don't merge it (yet). labels Oct 27, 2020
@cimnine cimnine modified the milestones: 0.26.1, 0.26.2 Oct 27, 2020
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
@comphilip
Copy link
Contributor Author

Thank you for investigating and the PR. Could it make sense to add the same functionality to configuration.docker.py?

I have no idea about it. It depends on how caller using it. It is ok not to add __dir__ if no dir calls.

While such bug is hard to resolve. Extra works need to make multi-loaded-module act as one traditional module since there are many special methods in python. There is no way to foreseen how caller using loaded module.

It is better to fail early if operations not supported.

@cimnine cimnine merged commit 80bfd98 into netbox-community:develop Oct 27, 2020
@cimnine cimnine mentioned this pull request Oct 27, 2020
3 tasks
@cimnine cimnine mentioned this pull request Dec 15, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a confirmed bug. hacktoberfest-accepted We think that such a PR is sufficiently good contribution, even if we don't merge it (yet).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants