Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError when using LOGIN_TIMEOUT #359

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Fix TypeError when using LOGIN_TIMEOUT #359

merged 2 commits into from
Nov 13, 2020

Conversation

devon-mar
Copy link
Contributor

Related Issue: #358

New Behavior

Casts LOGIN_TIMEOUT to int

Contrast to Current Behavior

LOGIN_TIMEOUT is a string causing logins to fail.

Discussion: Benefits and Drawbacks

Fixes #358

Proposed Release Note Entry

Fix LOGIN_TIMEOUT

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

cimnine
cimnine requested changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I have just one concern that I'd like you to address.

configuration/configuration.py Outdated Show resolved Hide resolved
@cimnine cimnine added the bug This issue describes a confirmed bug. label Nov 3, 2020
@cimnine cimnine added this to the 0.27.0 milestone Nov 3, 2020
@devon-mar @cimnine
Change LOGIN_TIMEOUT default to int
4276c94 
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
@cimnine cimnine changed the base branch from release to develop November 13, 2020 14:27
@cimnine cimnine merged commit 9d51762 into netbox-community:develop Nov 13, 2020
@cimnine cimnine mentioned this pull request Dec 15, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
bug This issue describes a confirmed bug.
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

TypeError when using LOGIN_TIMEOUT
2 participants
@devon-mar @cimnine