Closes #329: Draw rectangles around Sites/Locations/Racks #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
mattieserver
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to draw rectangles around Sites, Locations and Racks.
Three new checkboxes have been added to the filter form:
You can combine them as you like. You may show only sites...
locations...
racks...
a combination...
or simply all of them.
If you move device icons around, the rectangles will follow and will be redrawn.
group_feature.mp4
I thought it would be cool to be able to click on a rectangle in order to select all group members. Unfortunately I didn't manage to implement that. Either the graph listener interferes with my canvas listener or I'm doing something wrong. I gave up for now but if some of you guys have a good idea how to get it to work, don't hesitate to tell.