-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
477 prepare for netbox 4.0 #495
Conversation
Hello, @mattieserver @dreng is this completed? When will this get released? |
Oh yes! Just have a look at the checklist in issue #477. If you like to contribute, go for it! |
* Re-add overriding of default_renderer Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Restore i18n of field names Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Remove unnecessary FieldSets Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Remove trailing whitespaces in forms.py Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Fix error in resizeCanvas Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Remove btn-sm class from buttons Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> * Use htmx_partial instead of request.htmx Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org> --------- Signed-off-by: Iain Buclaw <ibuclaw@gdcproject.org>
Also the checkbox buttons are all over the place. I've raised it as a bug in upstream (netbox-community/netbox#16293) - it's obvious what the cause is, and you can sort of mitigate it by turning on the (experimental) HTMX navigation feature in user preferences. I'm opined to think that the appropriate fix would be for upstream to add the hidden input only if HTMX is enabled, but I don't have a good sense of how these templates piece together. |
Otherwise these will have to be replaced with a |
The only response I've gotten from upstream is that the use of BooleanField in searches being broken is not their problem. So migrating to NullBooleanField seems to be the only way out of this. |
Very disappointing. Anyway, thanks for trying. |
Yeah, with NullBooleanField it seems to work |
No description provided.