Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #497: Group by Virtual Chassis #542

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

dreng
Copy link
Collaborator

@dreng dreng commented Jul 29, 2024

Closes #497: Group by Virtual Chassis

Adds an option to draw a box around virtual chassis like it's done with sites, locations and racks.

@dreng dreng requested a review from mattieserver July 29, 2024 09:59
Copy link
Collaborator

@mattieserver mattieserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this works but we might also have to look into changing how devices are set on the map without coordinates so they at least are grouped logically. Because now you will have lots of overlapping boxes.

But that's for another issue.

@dreng
Copy link
Collaborator Author

dreng commented Jul 29, 2024

I guess this works but we might also have to look into changing how devices are set on the map without coordinates so they at least are grouped logically. Because now you will have lots of overlapping boxes.

But that's for another issue.

Feel free to add a FR. I'm afraid, this could be a dead end because of the way vis-network works. But at least we can give it a try.

@dreng dreng merged commit 6f43b95 into netbox-community:develop Jul 29, 2024
@dreng dreng deleted the 497_group_by_virtual_chassis branch August 21, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group by Virtual Chassis
2 participants