Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #163: Show raster and snap icons #550

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

dreng
Copy link
Collaborator

@dreng dreng commented Aug 14, 2024

Closes #163: Show raster and snap icons

This PR adds an option to set a grid size. For sizes > 0 a grid will be shown in the topology view. If the grid is active all icons snap to the grid when being dragged and dropped.

The grid size may be set as an individual option.

show_raster_and_snap_icons_preview.mp4

@mattieserver
Copy link
Collaborator

Should the grid size be something you set for the whole plugin and not only your user?

If I for example set the grid size to 2 and my colleagues to 5 it might result in some strange aligned icons.

@dreng
Copy link
Collaborator Author

dreng commented Aug 14, 2024

Should the grid size be something you set for the whole plugin and not only your user?

If I for example set the grid size to 2 and my colleagues to 5 it might result in some strange aligned icons.

I get your point but I think that this is not a problem of the plugin but a problem of team organization. It's somewhat similar to software developers who have to agree on coding conventions.

Even if you set this as a general option, it is possible that it comes to a different decision later ending in a different grid size. That would be the same result. Another scenario could be a colleague that doesn't use the grid at all while another one uses a fixed grid size and wonders why the icons are not placed on the grid anymore.

I see this feature as a helper to align and nicely arrange icons.

Another idea would be to hard code the size but personally I think that the decision which grid size is the right one should be on the user side.

@dreng dreng merged commit d2d2106 into netbox-community:develop Aug 20, 2024
@dreng dreng deleted the 163_show_raster_and_snap_icons branch August 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show raster and snap icons
2 participants