Fixes #2565: Improved rendering of Markdown tables

netbox-community · Nov 13, 2018 · 2fce7eb · 2fce7eb
1 parent 0c33af2
commit 2fce7eb
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ v2.4.8 (FUTURE)
 
 * [#2473](https://github.com/digitalocean/netbox/issues/2473) - Fix encoding of long (>127 character) secrets
 * [#2558](https://github.com/digitalocean/netbox/issues/2558) - Filter on all tags when multiple are passed
+* [#2565](https://github.com/digitalocean/netbox/issues/2565) - Improved rendering of Markdown tables
 * [#2575](https://github.com/digitalocean/netbox/issues/2575) - Correct model specified for rack roles table
 
 ---

diff --git a/netbox/project-static/css/base.css b/netbox/project-static/css/base.css
@@ -390,6 +390,19 @@ table.report th a {
     top: -51px;
 }
 
+/* Rendered Markdown */
+.rendered-markdown table {
+    width: 100%;
+}
+.rendered-markdown th {
+    border-bottom: 2px solid #dddddd;
+    padding: 8px;
+}
+.rendered-markdown td {
+    border-top: 1px solid #dddddd;
+    padding: 8px;
+}
+
 /* AJAX loader */
 .loading {
     position: fixed;

diff --git a/netbox/templates/circuits/circuit.html b/netbox/templates/circuits/circuit.html
@@ -131,7 +131,7 @@ <h1>{{ circuit }}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if circuit.comments %}
                     {{ circuit.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/circuits/provider.html b/netbox/templates/circuits/provider.html
@@ -129,7 +129,7 @@ <h1>{{ provider }}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if provider.comments %}
                     {{ provider.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/dcim/device.html b/netbox/templates/dcim/device.html
@@ -290,7 +290,7 @@ <h1>{{ device }}</h1>
                 <div class="panel-heading">
                     <strong>Comments</strong>
                 </div>
-                <div class="panel-body">
+                <div class="panel-body rendered-markdown">
                     {% if device.comments %}
                         {{ device.comments|gfm }}
                     {% else %}

diff --git a/netbox/templates/dcim/devicetype.html b/netbox/templates/dcim/devicetype.html
@@ -164,7 +164,7 @@ <h1>{{ devicetype.manufacturer }} {{ devicetype.model }}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if devicetype.comments %}
                     {{ devicetype.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/dcim/rack.html b/netbox/templates/dcim/rack.html
@@ -164,7 +164,7 @@ <h1>{% block title %}Rack {{ rack }}{% endblock %}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if rack.comments %}
                     {{ rack.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/dcim/site.html b/netbox/templates/dcim/site.html
@@ -230,7 +230,7 @@ <h1>{% block title %}{{ site }}{% endblock %}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if site.comments %}
                     {{ site.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/tenancy/tenant.html b/netbox/templates/tenancy/tenant.html
@@ -87,7 +87,7 @@ <h1>{% block title %}{{ tenant }}{% endblock %}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if tenant.comments %}
                     {{ tenant.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/virtualization/cluster.html b/netbox/templates/virtualization/cluster.html
@@ -99,7 +99,7 @@ <h1>{% block title %}{{ cluster }}{% endblock %}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if cluster.comments %}
                     {{ cluster.comments|gfm }}
                 {% else %}

diff --git a/netbox/templates/virtualization/virtualmachine.html b/netbox/templates/virtualization/virtualmachine.html
@@ -143,7 +143,7 @@ <h1>{% block title %}{{ virtualmachine }}{% endblock %}</h1>
             <div class="panel-heading">
                 <strong>Comments</strong>
             </div>
-            <div class="panel-body">
+            <div class="panel-body rendered-markdown">
                 {% if virtualmachine.comments %}
                     {{ virtualmachine.comments|gfm }}
                 {% else %}