Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge several middleware classes #11489

Closed
jeremystretch opened this issue Jan 13, 2023 · 0 comments
Closed

Merge several middleware classes #11489

jeremystretch opened this issue Jan 13, 2023 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Merge the following middleware classes into one:

  • APIVersionMiddleware
  • DynamicConfigMiddleware
  • ExceptionHandlingMiddleware
  • LoginRequiredMiddleware
  • ObjectChangeMiddleware

Justification

Each of these middleware classes is responsible for a fairly minor yet crucial operation, and it doesn't really make sense that we would need to toggle them individually.

Note that I'm excluding RemoteUserMiddleware from this list, as it holds a considerable amount of custom logic, and we want to ensure it's always processed before the boilerplate stuff.

@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: accepted This issue has been accepted for implementation labels Jan 13, 2023
@jeremystretch jeremystretch self-assigned this Jan 13, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Jan 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

1 participant