Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Status column to Module Bays tables #11652

Closed
sleepinggenius2 opened this issue Feb 2, 2023 · 2 comments · Fixed by #12455
Closed

Add Status column to Module Bays tables #11652

sleepinggenius2 opened this issue Feb 2, 2023 · 2 comments · Fixed by #12455
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v3.4.3

Feature type

Change to existing functionality

Proposed functionality

A Status field was added to Modules in #10371. I am proposing making that field available as a column on the Module Bays tables (full list and tab under a device). There is existing precedent for Module fields to be added as column options for those tables, like Serial number and Asset tag. I would additionally propose adding that column as one of the defaults on those tables, as was done for the Modules table.

Use case

Adding this as a table column would increase its visibility and make it easier to understand at a glance the status of all the modules in a shelf. Currently, a user would need to click into a given module in the list to see its status, which becomes cumbersome on a shelf with many modules.

Database changes

None

External dependencies

None
@sleepinggenius2 sleepinggenius2 added the type: feature Introduction of new functionality to the application label Feb 2, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 3, 2023
@jeremystretch
Copy link
Member

It should be straightforward to add the table column, however a solution will be needed to display the badge label color correctly.

@abhi1693
Copy link
Member

abhi1693 commented May 3, 2023

I'll take a stab at this.

@abhi1693 abhi1693 self-assigned this May 3, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 3, 2023
abhi1693 added a commit that referenced this issue May 3, 2023
@abhi1693
adds module status to module bay table #11652
c4a64ce
@abhi1693 abhi1693 mentioned this issue May 3, 2023
Merged
jeremystretch pushed a commit that referenced this issue May 4, 2023
@abhi1693
Adds module status to module bay table (#12455)
ea8a013 
* adds module status to module bay table #11652

* removed the extra line

* updated field name
jeremystretch added a commit that referenced this issue May 4, 2023
@jeremystretch
Changelog for #10757, #11652, #11791, #11190, #12363, #12464
3eba65b
@jeremystretch jeremystretch mentioned this issue May 5, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds module status to module bay table netbox-community/netbox
3 participants
@abhi1693 @jeremystretch @sleepinggenius2