Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeLoggedModel should inherit WebhooksMixin #11737

Closed
jeremystretch opened this issue Feb 11, 2023 · 0 comments
Closed

ChangeLoggedModel should inherit WebhooksMixin #11737

jeremystretch opened this issue Feb 11, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.5

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Add WebhooksMixin to the list of superclasses from which ChangeLoggedModel inherits.

Justification

Every subclass of ChangeLoggedModel currently also inherit from WebhooksMixin, with two exceptions:

  • extras.Branch
  • extras.StagedChange

This change will effectively enable webhooks for the two models above, which I believe is reasonable.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Feb 11, 2023
@jeremystretch jeremystretch self-assigned this Feb 11, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Feb 11, 2023
jeremystretch added a commit that referenced this issue Feb 11, 2023
@jeremystretch
Closes #11737: ChangeLoggedModel should inherit WebhooksMixin
c99ecc2
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
Closes #11737: ChangeLoggedModel should inherit WebhooksMixin
ade56fe
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
Closes #11737: ChangeLoggedModel should inherit WebhooksMixin
96a79c2
@jeremystretch jeremystretch mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.5
Development

No branches or pull requests
1 participant
@jeremystretch