Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move account views & related resources into a separate Django app #13309

Closed
jeremystretch opened this issue Jul 30, 2023 · 0 comments
Closed

Move account views & related resources into a separate Django app #13309

jeremystretch opened this issue Jul 30, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.6

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move the following resources to a new account app:

  • All user-specific views (profile, preferences, password change form, etc.)
  • URL patterns for user-specific views
  • The UserToken proxy model

Similarly, all templates for user-specific views shall be moved from templates/users/account/ to templates/account/.

Justification

Following on from #12590, it has become apparent that a separate app should be used to contain resources used exclusively for user account management. This will allow us to better organize user-specific views and their related resources from the conventional models under the users app. It will also better enable us to employ the UserToken proxy model for users to manage their own API tokens.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jul 30, 2023
@jeremystretch jeremystretch self-assigned this Jul 30, 2023
@jeremystretch jeremystretch mentioned this issue Jul 30, 2023
Merged
@jeremystretch jeremystretch added this to the v3.6 milestone Jul 31, 2023
jeremystretch added a commit that referenced this issue Jul 31, 2023
@jeremystretch
Closes #13309: Introduce the account app (#13310)
80376ab 
* Introduce 'accounts' app for user-specific views & resources
* Move UserTokenTable to account app
* Move login & logout views to account app
@jeremystretch jeremystretch mentioned this issue Aug 30, 2023
Merged
@litebito litebito mentioned this issue Sep 1, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.6
Development

No branches or pull requests
1 participant
@jeremystretch