Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not reflected correctly when deleting a primary ip for a device #14532

Closed
blipnet opened this issue Dec 15, 2023 · 2 comments · Fixed by #14589
Closed

Changes are not reflected correctly when deleting a primary ip for a device #14532

blipnet opened this issue Dec 15, 2023 · 2 comments · Fixed by #14589
Assignees
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@blipnet
Copy link

blipnet commented Dec 15, 2023

Deployment Type

Self-hosted

NetBox Version

v3.5.7

Python Version

3.8

Steps to Reproduce

  1. create a device with and an interface on device
  2. create an IP-address and associate it to interface and make it primary ip
  3. delete the IP-address

When deleting the IP-address changelog gets two entries, first one as update on device and then delete of IP-address

Expected Behavior

The device update should have following:
pre-change - original device data
post-change - the device data with null as primary_ip

Observed Behavior

The device update gets following:
pre-change - "Warning: Comparing non-atomic change to previous change record"
post-change - the device data, and it also has an IP-address id as primary_ip

Same behavior is seen in webhooks

@blipnet blipnet added the type: bug A confirmed report of unexpected behavior in the application label Dec 15, 2023
@DanSheps
Copy link
Member

Thank you for opening a bug report. I was unable to reproduce the reported behavior on NetBox v3.6.6. Please re-confirm the reported behavior on the current stable release and adjust your post above as necessary. Remember to provide detailed steps that someone else can follow using a clean installation of NetBox to reproduce the issue. Remember to include the steps taken to create any initial objects or other data.

@DanSheps DanSheps added the status: revisions needed This issue requires additional information to be actionable label Dec 15, 2023
@blipnet
Copy link
Author

blipnet commented Dec 18, 2023

I have now tested the same on Netbox DEMO page with same behavior. I hope this gives you a better view of the issue.

Preparation:

  1. create a device role named A
  2. create a device type named A
  3. create a device named A with device role A and device type A
  4. create an interface on device named eth
  5. create an IP-address named 1.2.3.4/24 and assign to device A interface eth, check the checkbox to make it primary

Now when deleting the IP-address we get two change logs.

  1. Update on device A
  2. Delete of IP-address 1.2.3.4/24
    The change log on device never shows the update of primary IP

Below is from Netbox Demo page
image
image
image

@DanSheps DanSheps removed the status: revisions needed This issue requires additional information to be actionable label Dec 18, 2023
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows labels Dec 21, 2023
@jeremystretch jeremystretch self-assigned this Dec 21, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 21, 2023
jeremystretch added a commit that referenced this issue Dec 21, 2023
jeremystretch added a commit that referenced this issue Dec 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
3 participants