Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Event Rule Action Type only works one way #14550

Closed
rodvand opened this issue Dec 18, 2023 · 0 comments
Closed

Changing Event Rule Action Type only works one way #14550

rodvand opened this issue Dec 18, 2023 · 0 comments
Assignees
@arthanson @jeremystretch
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@rodvand
Copy link
Contributor

rodvand commented Dec 18, 2023

Deployment Type

Self-hosted

NetBox Version

v3.7-beta1

Python Version

3.8

Steps to Reproduce

  1. Create a webhook (anything goes)
  2. Create an Event Rule with Webhook as Action Type and select the new Webhook in the dropdown
  3. Save the Event rule
  4. Edit the Event rule and try changing the Action Type from Webhook to Script

Expected Behavior

The changing of the Action Type should change the input field to allow selection of a script.

Observed Behavior

It does not change. If you do it the other way around, changing from Script to Webhook seems to work as expected.
@rodvand rodvand added the type: bug A confirmed report of unexpected behavior in the application label Dec 18, 2023
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Dec 19, 2023
@arthanson arthanson self-assigned this Dec 19, 2023
@arthanson arthanson mentioned this issue Dec 19, 2023
Closed
jeremystretch added a commit that referenced this issue Dec 20, 2023
@jeremystretch
Fixes #14550: Fix changing event rule action type from webhook to script
78c8982
@jeremystretch jeremystretch mentioned this issue Dec 20, 2023
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Dec 21, 2023
@jeremystretch jeremystretch self-assigned this Dec 22, 2023
jeremystretch added a commit that referenced this issue Dec 22, 2023
@jeremystretch
Fixes #14550: Fix changing event rule action type from webhook to scr…
00807d1 
…ipt (#14571)

* Fixes #14550: Fix changing event rule action type from webhook to script

* Remove action_parameters from form; set on instance under save()
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rodvand @arthanson @jeremystretch