Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH Group 15 (3072) not selectable in UI #14793

Closed
jonkerj opened this issue Jan 15, 2024 · 1 comment · Fixed by #14794
Closed

DH Group 15 (3072) not selectable in UI #14793

jonkerj opened this issue Jan 15, 2024 · 1 comment · Fixed by #14794
Assignees
@jonkerj
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jonkerj
Copy link
Contributor

jonkerj commented Jan 15, 2024 •
edited
Loading

Deployment Type

Self-hosted

NetBox Version

v3.7.0

Python Version

3.11

Steps to Reproduce

  1. Open vpn/ike proposals in UI
  2. Try to select DH group 15

Expected Behavior

A dropdown containing group 15

Observed Behavior

DH group 15 is missing
@jonkerj jonkerj added the type: bug A confirmed report of unexpected behavior in the application label Jan 15, 2024
@jonkerj
Copy link
Contributor Author

jonkerj commented Jan 15, 2024

I noticed a missing line in netbox/vpn/choices.py, so I'll send in a PR

jonkerj added a commit to jonkerj/netbox that referenced this issue Jan 15, 2024
@jonkerj
fix: add missing DH group 15 (3072)
4b47fd6 
DH group 15 was not selectable in the UI, and I strongly suspect this
patch will fix that, as that particular choices was missing in
`choices.py`.

Signed-off-by: Jorik Jonker <jorik@kippendief.biz>

Fixes netbox-community#14793
@jonkerj jonkerj mentioned this issue Jan 15, 2024
Merged
@jeremystretch jeremystretch self-assigned this Jan 16, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Jan 16, 2024
jeremystretch pushed a commit that referenced this issue Jan 16, 2024
@jonkerj @jeremystretch
fix: add missing DH group 15 (3072)
c5cbb99 
DH group 15 was not selectable in the UI, and I strongly suspect this
patch will fix that, as that particular choices was missing in
`choices.py`.

Signed-off-by: Jorik Jonker <jorik@kippendief.biz>

Fixes #14793
jeremystretch added a commit that referenced this issue Jan 16, 2024
@jeremystretch
Changelog for #13844, #14778, #14791, #14793
1235b49
@jeremystretch jeremystretch mentioned this issue Jan 17, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonkerj jonkerj

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing DH group 15 (3072) jonkerj/netbox
2 participants
@jonkerj @jeremystretch