Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the annotated_date() and annotated_now() template filters #15736

Closed
jeremystretch opened this issue Apr 16, 2024 · 0 comments
Closed

Remove the annotated_date() and annotated_now() template filters #15736

jeremystretch opened this issue Apr 16, 2024 · 0 comments
Assignees
@jeremystretch
Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the following template filters from utilities.templatetags.helpers:

  • annotated_date()
  • annotated_now()

Justification

With the shift to using ISO 8601-formatted dates & times everywhere in #15735, these filters are no longer needed.

Impact

All uses of these filters must be updated. These can generally be replaced with the new isodatetime() template filter.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Apr 16, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Apr 16, 2024
@jeremystretch jeremystretch self-assigned this Apr 16, 2024
@jeremystretch jeremystretch mentioned this issue Apr 16, 2024
Closed
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15736: Remove annotated_date() template filter and annotated_…
2192775 
…now() template tag
@jeremystretch jeremystretch mentioned this issue Apr 17, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15736: Remove annotated_date() template filter and annotated_…
75d6bfe 
…now() template tag
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label May 9, 2024
K0HAX added a commit to K0HAX/netbox-powerdns-sync that referenced this issue May 24, 2024
@K0HAX
Changed annotated_date to isodatetime
a778286 
annotated_date was removed in netbox-community/netbox#15736
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch