Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The empty_text in BaseTable is not translatable because it does not utilize gettext_lazy #16051

Closed
grncbg opened this issue May 9, 2024 · 2 comments · Fixed by #16052
Closed

The empty_text in BaseTable is not translatable because it does not utilize gettext_lazy #16051

grncbg opened this issue May 9, 2024 · 2 comments · Fixed by #16052
Assignees
@grncbg
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@grncbg
Copy link
Contributor

grncbg commented May 9, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.0

Python Version

3.10

Steps to Reproduce

The empty_text in BaseTable is not translatable because it does not utilize gettext_lazy.

netbox/netbox/netbox/tables/tables.py

Lines 54 to 55 in 0cc2963

if self.empty_text is None:
self.empty_text = f"No {self._meta.model._meta.verbose_name_plural} found"

English
English

Japanese
Japanese

Expected Behavior

empty_text can be translated

Observed Behavior

empty_text cannot be translated
@grncbg grncbg added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 9, 2024
grncbg added a commit to grncbg/netbox that referenced this issue May 9, 2024
@grncbg
Fixes netbox-community#16051: Wrap empty_text with gettext_lazy()
19b151a
@abhi1693 abhi1693 assigned grncbg and unassigned abhi1693 May 9, 2024
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 9, 2024
@abhi1693
Copy link
Member

abhi1693 commented May 9, 2024

@grncbg I have assigned the bug to you since you already have a fix.

@grncbg grncbg mentioned this issue May 9, 2024
Merged
@jeremystretch
Copy link
Member

Please remember to assign a severity when triaging bug reports.

@jeremystretch jeremystretch added the severity: low Does not significantly disrupt application functionality, or a workaround is available label May 9, 2024
jeremystretch pushed a commit that referenced this issue May 9, 2024
@grncbg @jeremystretch
Fixes #16051: Wrap empty_text with gettext_lazy()
f40fb6a
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grncbg grncbg

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16051: Wrap empty_text with gettext_lazy() grncbg/netbox
3 participants
@abhi1693 @jeremystretch @grncbg