Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status color background is not distinguishable #16385

Closed
opericgithub opened this issue Jun 3, 2024 · 3 comments · Fixed by #17275
Closed

status color background is not distinguishable #16385

opericgithub opened this issue Jun 3, 2024 · 3 comments · Fixed by #17275
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@opericgithub
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.0.3

Python Version

3.10

Steps to Reproduce

Not actually a real bug, but more of a suggestion.
When changing the background color values ​​for the prefix statuses in the "FIELD_CHOICES" section of the configuration.py file, it is very difficult to distinguish black, gray and white colors. in the previous version (v3.x) the difference was much more obvious.

Expected Behavior

v3 black:
image

v3 gray:
image

v3 white:
image

Observed Behavior

v4 black:
image

v4 gray:
image

v4 white:
image

@opericgithub opericgithub added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jun 3, 2024
@jeffgdotorg
Copy link
Contributor

Thanks for reporting this low visual contrast issue. I'm putting it through and assigning low severity, partly because there's a comprehensive rework of contrast planned for v4.1 under #16390.

@jeffgdotorg jeffgdotorg added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Jun 4, 2024
@jeffgdotorg jeffgdotorg removed their assignment Jun 4, 2024
@jeremystretch jeremystretch added the topic: UI/UX User interface or user experience related work label Jun 17, 2024
@jeremystretch jeremystretch self-assigned this Jun 17, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 17, 2024
@jeremystretch
Copy link
Member

Looks like we lost the black, white, and gray styles during the move to Bootstrap v5.3. We probably just need to create aliases for the native styles:

  • black -> dark
  • white -> light
  • gray -> secondary

@jeremystretch
Copy link
Member

Bootstrap docs for reference. Custom colors need to be defined in styles/overrides/_bootstrap.scss.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants