Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish product types visually (OSS, Cloud, Enterprise) #16394

Closed
andrewgormley opened this issue Jun 3, 2024 · 2 comments
Closed

Distinguish product types visually (OSS, Cloud, Enterprise) #16394

andrewgormley opened this issue Jun 3, 2024 · 2 comments
Assignees
@andrewgormley
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Milestone
v4.1

Comments

@andrewgormley
Copy link
Contributor

andrewgormley commented Jun 3, 2024 •
edited by jeremystretch
Loading

NetBox version

v4.0.3

Feature type

New functionality

Proposed functionality

Distinguish between OSS, Cloud and Enterprise products through visual changes when users are logged in. This should occur through slightly different branded experiences such as adding a label below the logo with the name of the product type. Also using an alternate colour/gradient to subtly alter the theme which is bespoke to that product type.

Use case

Users will immediately know which application they are using. By adding this feature it will also open the door to future theming and branded experiences.

Database changes

No response

External dependencies

No response
@andrewgormley andrewgormley added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Jun 3, 2024
@jeremystretch
Copy link
Member

This should occur through slightly different branded experiences such as adding a label below the logo with the name of the product type.

@andrewgormley how would you like to accomplish this? Do we need to package alternative logos (images), or will this be text-based?

Also, marking this as blocked by #15908, which will introduce support for declaring a NetBox "edition" (e.g. Cloud, Enterprise, community).

@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation topic: UI/UX User interface or user experience related work and removed status: needs triage This issue is awaiting triage by a maintainer labels Jun 4, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Jun 25, 2024
@jeffgdotorg jeffgdotorg added this to the v4.1 milestone Jun 25, 2024
@jeremystretch
Copy link
Member

Just noting that this is no longer blocked as #15908 has been completed. Let's prioritize this work for next week.

andrewgormley pushed a commit to andrewgormley/netbox that referenced this issue Jul 16, 2024
closes netbox-community#16394: distinguish product edition
4e52443
@andrewgormley andrewgormley mentioned this issue Jul 16, 2024
Merged
jeremystretch added a commit that referenced this issue Jul 19, 2024
@andrewgormley @jeremystretch
16394 distinguish product edition (#16924)
5e25067 
* closes #16907: web ui refresh

* closes #16907: changed default widget color to primary color

* closes #16907: removed comma

* closes #16394: distinguish product edition

* Revert dashboard changes

* Clean up redundant styling (merge error)

* removed labs logo and added sub text for all editions

* fixed motif bug

* Fix "flashing" of side nav under dark mode

* Use title case for edition label

* altered edition text style

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch added a commit that referenced this issue Aug 2, 2024
@jeremystretch @andrewgormley
Feature UI (#17069)
02dd1a3 
* 16649 general contrast issues (#16759)

* fixes #16647: navigation contrast issues updated

* fixes #16651: table contrast issues new

* fixed #16649: general contrast issues

* fixes #16649: feedback changes

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.broadband>

* 16648 dashboard contrast issues (#16824)

* fixed #16648: dashboard contrast issues

* reinstate amendment to 16649

* fixed #16648: created gridstack override and removed inline bug fix

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>

* fixed #16853: accessibility issues

* fixed #16847: updated font (#16848)

* fixed #16847: updated font

* fixed #16847: changed font to local and added current font as fallback

* fixed #16847: removed inter and added padding to page header

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16849 document hierarchy issues (#16875)

* fixed #16849: h elements not in sequential order

* fixed #16849: Lists do not contain only li elements

* fixed #16849: fixed h hierarchy on rack object pages

* Remove standalone h5 classes

* Remove unnecessary line breaks

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16650 button contrast issues (#16845)

* fixed #16650: button contrast issues

* fixed #16650: green bg text contrast issue

* Revert errant JS resource updates

* Revert custom button colors

* Fix indentation

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16907 web UI refresh (#16915)

* closes #16907: web ui refresh

* closes #16907: changed default widget color to primary color

* closes #16907: removed comma

* Revert dashboard widget color changes

* Rename logo images for consistency

* Restore original dashboard widget config

* Remove .navbar-brand-autodark from logo

* Restore logo file names

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16394 distinguish product edition (#16924)

* closes #16907: web ui refresh

* closes #16907: changed default widget color to primary color

* closes #16907: removed comma

* closes #16394: distinguish product edition

* Revert dashboard changes

* Clean up redundant styling (merge error)

* removed labs logo and added sub text for all editions

* fixed motif bug

* Fix "flashing" of side nav under dark mode

* Use title case for edition label

* altered edition text style

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* Query release features to toggle commercial theme

* fixes dark mode primary button contrast issue

* fixes #16913: hidden admin nav link (#16978)

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* fixed 16852: misc accessbility problems (#16977)

* fixed 16852: misc accessbility problems

* Restore tooltip text

* Add translation support

* Add missing i18n

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* fixes issues in #16850 (#16986)

* fixes issues in #16850: issue 3 and 5

* Add link text for 'clear' button on table column

* Translate aria label

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* Use alternate footer links for commercial releases

* Remove Inter font

* Adjust base font weight to 500

* Retain default text color for hyperlinks inside tables

* Logo & edition cleanup

* Move dashboard styling

* Misc cleanup

* Remove unused styles

* Misc cleanup & refactoring

---------

Co-authored-by: Andrew Gormley <andrewgormley91@gmail.com>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.broadband>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewgormley andrewgormley

Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.1
Development

No branches or pull requests
4 participants
@jeffgdotorg @DanSheps @jeremystretch @andrewgormley