Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Edit and delete on all resources does not work when "HTMX Navigation" is enabled #16542

Closed
akienz opened this issue Jun 13, 2024 · 0 comments · Fixed by #16626
Closed

Bulk Edit and delete on all resources does not work when "HTMX Navigation" is enabled #16542

akienz opened this issue Jun 13, 2024 · 0 comments · Fixed by #16626
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation topic: htmx navigation For issues where HTMX navigation is enabled type: bug A confirmed report of unexpected behavior in the application

Comments

@akienz
Copy link

akienz commented Jun 13, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.5

Python Version

3.11

Steps to Reproduce

  1. Enable "HTMX Navigation" in User Preferences > Preferences and save
  2. Go to the list view of any resource, select some and click on "Edit selected"
  3. Do any modification and click on "Apply"
  4. POST-Request will fail because of invalid URL

This also applies for bulk delete with the same behaviour

Expected Behavior

The changes made on the selected resources should be applied

Observed Behavior

When clicking on edit the user gets redirected to the wrong url, i.e.

https://<instance-url>/dcim/devices/%22true%22

instead of

https://<instance-url>/dcim/devices/edit

The edit dialogue appears as expected but saving is not possible because of wrong URL in the POST-Request:

netbox error

Could recreate this in MS Edge, Chrome and Firefox, so it doesn't seem like a client issue. Also tested locally with a fresh netbox installation in docker with the same behaviour
@akienz akienz added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jun 13, 2024
@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs triage This issue is awaiting triage by a maintainer labels Jun 13, 2024
@jeremystretch jeremystretch added the topic: htmx navigation For issues where HTMX navigation is enabled label Jun 14, 2024
@jeremystretch jeremystretch self-assigned this Jun 17, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 17, 2024
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
Fixes #16542: Fix bulk form operations when HTMX is enabled
dc7eaa8
@jeremystretch jeremystretch mentioned this issue Jun 17, 2024
Merged
jeremystretch added a commit that referenced this issue Jun 18, 2024
@jeremystretch
Update changelog for #15348, #16416, #16444, #16450, #16452, #16460, #…
9d28af4 
…16512, #16542
@jeremystretch jeremystretch mentioned this issue Jun 24, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation topic: htmx navigation For issues where HTMX navigation is enabled type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16542: Fix bulk form operations when HTMX is enabled netbox-community/netbox
3 participants
@DanSheps @jeremystretch @akienz