Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning DeviceType with 0U height doesn't work #16714

Closed
llamafilm opened this issue Jun 24, 2024 · 3 comments · Fixed by #16741
Closed

Cloning DeviceType with 0U height doesn't work #16714

llamafilm opened this issue Jun 24, 2024 · 3 comments · Fixed by #16741
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@llamafilm
Copy link
Contributor

Deployment Type

NetBox Cloud

NetBox Version

v4.0.5

Python Version

3.12

Steps to Reproduce

  1. Import any Device Type with 0U height (example)
  2. Clone it

Expected Behavior

The mandatory height field should be pre-filled with the number 0.

Observed Behavior

The height field is blank.

The Clone button URL is missing the number: https://localhost/dcim/device-types/add/?manufacturer=173&u_height=&is_full_depth=&airflow=right-to-left&weight=2.93&weight_unit=lb

@llamafilm llamafilm added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jun 24, 2024
@jeffgdotorg
Copy link
Contributor

Thanks for the report @llamafilm. I've reproduced it in a fresh NetBox 4.0.6 instance and confirmed that hacking the a.href of the Clone button element to include u_height=0.0 results in the value carrying over to the Add form.

Moving along to needs owner status. If you or anybody else with the requisite skills and capacity would like to work it through to a PR, just chime in and a maintainer will assign the issue to you.

@jeffgdotorg jeffgdotorg removed their assignment Jun 26, 2024
@jeffgdotorg jeffgdotorg added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Jun 26, 2024
@llamafilm
Copy link
Contributor Author

Looks like just one line, I can fix it

@arthanson
Copy link
Collaborator

I'll assign to you @llamafilm

@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants