Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more commit rate values #16817

Closed
AdamBrutsaert opened this issue Jul 4, 2024 · 2 comments · Fixed by #16821
Closed

Add more commit rate values #16817

AdamBrutsaert opened this issue Jul 4, 2024 · 2 comments · Fixed by #16821
Assignees
@AdamBrutsaert
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@AdamBrutsaert
Copy link
Contributor

NetBox version

v4.0.6

Feature type

Data model extension

Proposed functionality

Add 200 and 400 GBPS commit rate for circuits

Use case

As #16791 added 200 and 400 GBPS circuit termination port speed, that would be also a QOL feature for circuit's commit rate

Database changes

No response

External dependencies

No response
@AdamBrutsaert AdamBrutsaert added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Jul 4, 2024
@AdamBrutsaert AdamBrutsaert changed the title Add more commit_rate values Add more commit rate values Jul 4, 2024
@jeremystretch jeremystretch removed their assignment Jul 4, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Jul 4, 2024
@AdamBrutsaert
Copy link
Contributor Author

I'm willing to take ownership if needed to make a PR,

It is just adding two lines there https://github.com/netbox-community/netbox/blob/develop/netbox/circuits/choices.py#L30C1-L43C6

        (200000000, '200 Gbps'),
        (400000000, '400 Gbps'),

@jeremystretch
Copy link
Member

@AdamBrutsaert thanks, I've assigned this to you.

@AdamBrutsaert AdamBrutsaert mentioned this issue Jul 4, 2024
Merged
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jul 4, 2024
jeremystretch added a commit that referenced this issue Jul 9, 2024
@jeremystretch
Changelog for #14554, #16721, #16758, #16802, #16808, #16817, #16843
aceed94
@jeffgdotorg jeffgdotorg mentioned this issue Jul 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AdamBrutsaert AdamBrutsaert

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16817: Added 200 & 400 Gbps selections for circuit commit rate AdamBrutsaert/netbox
2 participants
@jeremystretch @AdamBrutsaert