Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the list view bulk Rename buttons to have an opaque background #17802

Closed
atownson opened this issue Oct 17, 2024 · 1 comment · Fixed by #17805
Closed

Update the list view bulk Rename buttons to have an opaque background #17802

atownson opened this issue Oct 17, 2024 · 1 comment · Fixed by #17805
Assignees
@atownson
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@atownson
Copy link
Contributor

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v4.1.4

Python Version

3.10

Steps to Reproduce

  1. Create about 20 devices and navigate to the Device list view
  2. Select/check one or more of the rows so the bulk operations buttons float

Templates affected:

  1. templates/dcim/device_list.html
  2. templates/dcim/component_list.html

These templates were overlooked in #17523. Adding the btn-float class to the Rename button fixes the issue.

Expected Behavior

The Rename button should have an opaque background to avoid clashing with the form list items.

image

Observed Behavior

The Rename button has a transparent background.

image
@atownson atownson added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Oct 17, 2024
@arthanson arthanson added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Oct 17, 2024
@arthanson
Copy link
Collaborator

@atownson I've assigned you the issue.

@atownson atownson mentioned this issue Oct 17, 2024
Merged
jeremystretch added a commit that referenced this issue Oct 21, 2024
@jeremystretch
Changelog for #17374, #17635, #17774, #17802, #17789
5940f5f
@jeremystretch jeremystretch mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atownson atownson

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #17802 - Added opaque background to Rename buttons atownson/netbox
2 participants
@arthanson @atownson