Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP Authentication Documentation #203

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

dinoocch
Copy link
Contributor

@dinoocch dinoocch commented Jul 6, 2016

Addresses #65

This commit adds documentation for installing and configuring ldap
authentication for netbox.

It may be beneficial to add settings to the configuration.py instead of
editing settings.py if this is commonly used.

Addresses netbox-community#65

This commit adds documentation for installing and configuring ldap
authentication for netbox.

It may be beneficial to add settings to the configuration.py instead of
editing settings.py if this is an important feature.
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jul 6, 2016
@jeremystretch
Copy link
Member

jeremystretch commented Jul 6, 2016

This is excellent! However, I'd like to port the LDAP configuration variables into configuration.example.py. It probably makes sense to go ahead and bake the dependencies into NetBox as well, but I'll defer to whatever consensus is reached in #65.

@dinoocch
Copy link
Contributor Author

dinoocch commented Jul 6, 2016

Sure, sounds good! I'll drop a commit on top later tonight with that change so that whatever choice is made is good to go.

@jeremystretch jeremystretch merged commit 68515b9 into netbox-community:develop Jul 8, 2016
@jeremystretch
Copy link
Member

@dinoocch I rewrote a good deal of your original draft to move the config out of settings.py. Please let me know what you think and/or submit a PR for any further changes: http://netbox.readthedocs.io/en/latest/installation/ldap/

@jeremystretch jeremystretch removed the status: accepted This issue has been accepted for implementation label Jul 8, 2016
@jeremystretch jeremystretch mentioned this pull request Jul 8, 2016
if-fi pushed a commit to if-fi/netbox that referenced this pull request Oct 1, 2016
Add LDAP Authentication Documentation
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants