Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a query filter for every object type #2101

Closed
jeremystretch opened this issue May 21, 2018 · 2 comments · Fixed by #7824
Closed

Add a query filter for every object type #2101

jeremystretch opened this issue May 21, 2018 · 2 comments · Fixed by #7824
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Issue type

[x] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: 2.3.3

Description

For the sake of consistency, we should have a query filter for each object type, even if it's empty. Some views, like BulkEditView and BulkDeleteView, rely on the presence of a filter for performing bulk operations on all objects matching a parameter (e.g. deleting all devices matching a certain name, instead of just those selected in the list).

This was inspired by the issue raised in #2097.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels May 21, 2018
@jeremystretch jeremystretch mentioned this issue May 21, 2018
Closed
@jeremystretch jeremystretch mentioned this issue Feb 14, 2020
Closed
@jeremystretch
Copy link
Member Author

Per #3998 this should include the console/power/interface connection views as well.

@jeremystretch jeremystretch self-assigned this May 21, 2021
@jeremystretch
Copy link
Member Author

It looks like this issue has mostly been addressed already. The remaining filtersets which need a q filter are:

  • dcim/DeviceTypeComponentFilterSet
  • dcim/ConnectionFilterSet
  • extras/WebhookFilterSet
  • extras/CustomFieldFilterSet
  • extras/CustomLinkFilterSet
  • extras/ExportTemplateFilterSet
  • extras/ImageAttachmentFilterSet
  • users/ObjectPermissionFilterSet

jeremystretch added a commit that referenced this issue Nov 12, 2021
@jeremystretch
Changelog for #2101
f3beabb
@jeremystretch jeremystretch mentioned this issue Nov 12, 2021
Merged
jeremystretch added a commit that referenced this issue Nov 12, 2021
@jeremystretch
Merge pull request #7824 from netbox-community/2101-q-filters
98cc36c 
Closes #2101: Ensure all relevant models have a general purpose search filter
@jeremystretch jeremystretch mentioned this issue Nov 24, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
1 participant
@jeremystretch