Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginator appears twice on child prefixes/IPs view #2795

Closed
jeremystretch opened this issue Jan 17, 2019 · 4 comments
Closed

Paginator appears twice on child prefixes/IPs view #2795

jeremystretch opened this issue Jan 17, 2019 · 4 comments
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Environment

  • Python version: 3.5.2
  • NetBox version: 2.5.3

Steps to Reproduce

  1. Find a prefix with one or more child prefixes
  2. Click the "prefixes" tab to view the child prefixes

Expected Behavior

The list pagination widget should be displayed only once.

Observed Behavior

The list pagination widget appears twice. This also occurs when viewing child IP addresses within a prefix.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Jan 17, 2019
@mmahacek
Copy link
Contributor

I was just coming here to post this. My uneducated guess makes me think there is something with both netbox/templates/utilities/obj_table.html and netbox/templates/panel_table.html having references to including the paginator.

@jeremystretch
Copy link
Member Author

The table templates are a bit of a mess overall. I need to track down all the various implementations and standardize on a single incantation.

@mmahacek
Copy link
Contributor

This doesn’t seem to be a breaking issue, and I haven’t found it happening on any other page.

@jeremystretch
Copy link
Member Author

For reference, here's the current template tree. Note that the paginator gets included twice.

- ipam/prefix_prefixes.html
    - utilities/obj_table.html (with table_template='panel_table.html')
        - panel_table.html
            - inc/paginator.html
        - inc/paginator.html

@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants