Fixes GenericForeignKey validation #11550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanSheps Could you please review this as you had assigned me the issues? If there are changes needed, I'd be happy to make them |
DanSheps
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Looks good to me, however I would like @jeremystretch to review it.
jeremystretch
requested changes
Apr 10, 2023
There was a problem hiding this comment.
Thanks @abhi1693, and sorry for the delay in getting to this.
This was referenced Apr 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10221, #11454
Added a validation on
NetBoxModelclean()method for GenericForeignKey fields to ensure that the content type and object ID exist.