Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #11732: Protect against errant overwriting of data via web UI forms #13332

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Closes #11732: Protect against errant overwriting of data via web UI forms #13332

merged 1 commit into from
Aug 1, 2023

Conversation

jeremystretch
Copy link
Member

Closes: #11732

  • Introduce CheckLastUpdatedMixin, which adds the optional field _init_time and validation to check against an object's last_updated value
  • NetBoxModelForm now inherits from CheckLastUpdatedMixin

jsenecal
jsenecal approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jsenecal jsenecal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and elegant to me!

@jeremystretch jeremystretch merged commit 43e6308 into feature Aug 1, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 11732-form-race-protection branch August 1, 2023 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsenecal jsenecal jsenecal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @jsenecal